diff options
author | Christoph Paasch <christoph.paasch@uclouvain.be> | 2014-01-21 13:30:26 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-01-23 06:26:16 +0100 |
commit | 00ca9c5b2b11d44eaf20a4b647efc999734323ec (patch) | |
tree | fbcafcdcc52950691a0430ad377448216fbcfd84 /net/bridge/br_vlan.c | |
parent | Merge branch 'bonding' (diff) | |
download | linux-00ca9c5b2b11d44eaf20a4b647efc999734323ec.tar.xz linux-00ca9c5b2b11d44eaf20a4b647efc999734323ec.zip |
tcp: metrics: Fix rcu-race when deleting multiple entries
In bbf852b96ebdc6d1 I introduced the tmlist, which allows to delete
multiple entries from the cache that match a specified destination if no
source-IP is specified.
However, as the cache is an RCU-list, we should not create this tmlist, as
it will change the tcpm_next pointer of the element that will be deleted
and so a thread iterating over the cache's entries while holding the
RCU-lock might get "redirected" to this tmlist.
This patch fixes this, by reverting back to the old behavior prior to
bbf852b96ebdc6d1, which means that we simply change the tcpm_next
pointer of the previous element (pp) to jump over the one we are
deleting.
The difference is that we call kfree_rcu() directly on the cache entry,
which allows us to delete multiple entries from the list.
Fixes: bbf852b96ebdc6d1 (tcp: metrics: Delete all entries matching a certain destination)
Signed-off-by: Christoph Paasch <christoph.paasch@uclouvain.be>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_vlan.c')
0 files changed, 0 insertions, 0 deletions