diff options
author | Ilya Dryomov <idryomov@gmail.com> | 2016-12-02 16:35:09 +0100 |
---|---|---|
committer | Ilya Dryomov <idryomov@gmail.com> | 2016-12-12 23:09:21 +0100 |
commit | b3bbd3f2ab19c8ca319003b4b51ce4c4ca74da06 (patch) | |
tree | bfb52f0ab116ce2d3f499719df19ea9a2788d209 /net/ceph/messenger.c | |
parent | libceph: drop len argument of *verify_authorizer_reply() (diff) | |
download | linux-b3bbd3f2ab19c8ca319003b4b51ce4c4ca74da06.tar.xz linux-b3bbd3f2ab19c8ca319003b4b51ce4c4ca74da06.zip |
libceph: no need to drop con->mutex for ->get_authorizer()
->get_authorizer(), ->verify_authorizer_reply(), ->sign_message() and
->check_message_signature() shouldn't be doing anything with or on the
connection (like closing it or sending messages).
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Diffstat (limited to 'net/ceph/messenger.c')
-rw-r--r-- | net/ceph/messenger.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/net/ceph/messenger.c b/net/ceph/messenger.c index dba380429a05..770c52701efa 100644 --- a/net/ceph/messenger.c +++ b/net/ceph/messenger.c @@ -1393,15 +1393,9 @@ static struct ceph_auth_handshake *get_connect_authorizer(struct ceph_connection return NULL; } - /* Can't hold the mutex while getting authorizer */ - mutex_unlock(&con->mutex); auth = con->ops->get_authorizer(con, auth_proto, con->auth_retry); - mutex_lock(&con->mutex); - if (IS_ERR(auth)) return auth; - if (con->state != CON_STATE_NEGOTIATING) - return ERR_PTR(-EAGAIN); con->auth_reply_buf = auth->authorizer_reply_buf; con->auth_reply_buf_len = auth->authorizer_reply_buf_len; |