diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2005-04-17 00:24:10 +0200 |
|---|---|---|
| committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-04-17 00:24:10 +0200 |
| commit | 6775cab98b89b2caa10dce4b07e2c81999e45517 (patch) | |
| tree | c24ede63d9f2eb303744d5c96c8f5294cee3c1db /net/core/dst.c | |
| parent | [PATCH] net: don't call kmem_cache_create with a spinlock held (diff) | |
| download | linux-6775cab98b89b2caa10dce4b07e2c81999e45517.tar.xz linux-6775cab98b89b2caa10dce4b07e2c81999e45517.zip | |
[PATCH] Fix dst_destroy() race
When we are not the real parent of the dst (e.g., when we're xfrm_dst and
the child is an rtentry), it may already be on the GC list.
In fact the current code is buggy to, we need to check dst->flags before
the dec as dst may no longer be valid afterwards.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'net/core/dst.c')
| -rw-r--r-- | net/core/dst.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/core/dst.c b/net/core/dst.c index 3bf6cc434814..fc434ade5270 100644 --- a/net/core/dst.c +++ b/net/core/dst.c @@ -198,13 +198,15 @@ again: dst = child; if (dst) { + int nohash = dst->flags & DST_NOHASH; + if (atomic_dec_and_test(&dst->__refcnt)) { /* We were real parent of this dst, so kill child. */ - if (dst->flags&DST_NOHASH) + if (nohash) goto again; } else { /* Child is still referenced, return it for freeing. */ - if (dst->flags&DST_NOHASH) + if (nohash) return dst; /* Child is still in his hash table */ } |