diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2024-12-18 03:25:08 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2024-12-19 04:22:51 +0100 |
| commit | 5eb70dbebf32c2fd1f2814c654ae17fc47d6e859 (patch) | |
| tree | 76175d9523c626ae65b0f8f982a69cfee2236ecf /net/core/netdev-genl.c | |
| parent | net: dsa: restore dsa_software_vlan_untag() ability to operate on VLAN-untagg... (diff) | |
| download | linux-5eb70dbebf32c2fd1f2814c654ae17fc47d6e859.tar.xz linux-5eb70dbebf32c2fd1f2814c654ae17fc47d6e859.zip | |
netdev-genl: avoid empty messages in queue dump
Empty netlink responses from do() are not correct (as opposed to
dump() where not dumping anything is perfectly fine).
We should return an error if the target object does not exist,
in this case if the netdev is down it has no queues.
Fixes: 6b6171db7fc8 ("netdev-genl: Add netlink framework functions for queue")
Reported-by: syzbot+0a884bc2d304ce4af70f@syzkaller.appspotmail.com
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Joe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/20241218022508.815344-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to '')
| -rw-r--r-- | net/core/netdev-genl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c index 1be8c7c21d19..2d3ae0cd3ad2 100644 --- a/net/core/netdev-genl.c +++ b/net/core/netdev-genl.c @@ -430,10 +430,10 @@ static int netdev_nl_queue_fill(struct sk_buff *rsp, struct net_device *netdev, u32 q_idx, u32 q_type, const struct genl_info *info) { - int err = 0; + int err; if (!(netdev->flags & IFF_UP)) - return err; + return -ENOENT; err = netdev_nl_queue_validate(netdev, q_idx, q_type); if (err) |