diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2014-03-15 04:47:15 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-03-17 20:47:22 +0100 |
| commit | e97dc3fcf98a32a5eda1e942a36044b95bc58099 (patch) | |
| tree | 871bfc6c4394a8aaad8b28ac4243a8e417307d99 /net/core/netpoll.c | |
| parent | netpoll: Visit all napi handlers in poll_napi (diff) | |
| download | linux-e97dc3fcf98a32a5eda1e942a36044b95bc58099.tar.xz linux-e97dc3fcf98a32a5eda1e942a36044b95bc58099.zip | |
netpoll: Warn if more packets are processed than are budgeted
There is already a warning for this case in the normal netpoll path,
but put a copy here in case how netpoll calls the poll functions
causes a differenet result.
netpoll will shortly call the napi poll routine with a budget 0 to
avoid any rx packets being processed. As nothing does that today
we may encounter drivers that have problems so a netpoll specific
warning seems desirable.
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/netpoll.c')
| -rw-r--r-- | net/core/netpoll.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/netpoll.c b/net/core/netpoll.c index d9e3d74ec9ac..2ad330e02967 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -158,6 +158,7 @@ static int poll_one_napi(struct napi_struct *napi, int budget) set_bit(NAPI_STATE_NPSVC, &napi->state); work = napi->poll(napi, budget); + WARN_ONCE(work > budget, "%pF exceeded budget in poll\n", napi->poll); trace_napi_poll(napi); clear_bit(NAPI_STATE_NPSVC, &napi->state); |