diff options
| author | Florian Westphal <fw@strlen.de> | 2019-05-31 18:27:09 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-06-03 03:08:36 +0200 |
| commit | 2638eb8b50cfc16240e0bb080b9afbf541a9b39d (patch) | |
| tree | 84264a6f50aaedfac6854bef3d5972926d321c10 /net/core/netpoll.c | |
| parent | drivers: use in_dev_for_each_ifa_rtnl/rcu (diff) | |
| download | linux-2638eb8b50cfc16240e0bb080b9afbf541a9b39d.tar.xz linux-2638eb8b50cfc16240e0bb080b9afbf541a9b39d.zip | |
net: ipv4: provide __rcu annotation for ifa_list
ifa_list is protected by rcu, yet code doesn't reflect this.
Add the __rcu annotations and fix up all places that are now reported by
sparse.
I've done this in the same commit to not add intermediate patches that
result in new warnings.
Reported-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/netpoll.c')
| -rw-r--r-- | net/core/netpoll.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/net/core/netpoll.c b/net/core/netpoll.c index dd8b1a460d64..2cf27da1baeb 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -696,16 +696,22 @@ int netpoll_setup(struct netpoll *np) if (!np->local_ip.ip) { if (!np->ipv6) { + const struct in_ifaddr *ifa; + in_dev = __in_dev_get_rtnl(ndev); + if (!in_dev) + goto put_noaddr; - if (!in_dev || !in_dev->ifa_list) { + ifa = rtnl_dereference(in_dev->ifa_list); + if (!ifa) { +put_noaddr: np_err(np, "no IP address for %s, aborting\n", np->dev_name); err = -EDESTADDRREQ; goto put; } - np->local_ip.ip = in_dev->ifa_list->ifa_local; + np->local_ip.ip = ifa->ifa_local; np_info(np, "local IP %pI4\n", &np->local_ip.ip); } else { #if IS_ENABLED(CONFIG_IPV6) |