diff options
author | Or Gerlitz <ogerlitz@mellanox.com> | 2014-12-14 17:19:05 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-12-16 21:41:19 +0100 |
commit | 65891feac27e26115dc4cce881743a1ac33372df (patch) | |
tree | 6203868aee4509125cff8a5fc7f24f622edb25b0 /net/core/rtnetlink.c | |
parent | net/mlx4: Cache line CQE/EQE stride fixes (diff) | |
download | linux-65891feac27e26115dc4cce881743a1ac33372df.tar.xz linux-65891feac27e26115dc4cce881743a1ac33372df.zip |
net: Disallow providing non zero VLAN ID for NIC drivers FDB add flow
The current implementations all use dev_uc_add_excl() and such whose API
doesn't support vlans, so we can't make it with NICs HW for now.
Fixes: f6f6424ba773 ('net: make vid as a parameter for ndo_fdb_add/ndo_fdb_del')
Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@resnulli.us>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/rtnetlink.c')
-rw-r--r-- | net/core/rtnetlink.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index d06107d36ec8..9cf6fe9ddc0c 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -2368,6 +2368,11 @@ int ndo_dflt_fdb_add(struct ndmsg *ndm, return err; } + if (vid) { + pr_info("%s: vlans aren't supported yet for dev_uc|mc_add()\n", dev->name); + return err; + } + if (is_unicast_ether_addr(addr) || is_link_local_ether_addr(addr)) err = dev_uc_add_excl(dev, addr); else if (is_multicast_ether_addr(addr)) |