diff options
| author | David Woodhouse <dwmw2@infradead.org> | 2008-05-20 23:36:14 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-05-20 23:36:14 +0200 |
| commit | 0e91796eb46e29edc791131c832a2232bcaed9dd (patch) | |
| tree | e175a4b0de48e9e44b94e52dd634d38618193add /net/core | |
| parent | net_sched: cls_api: fix return value for non-existant classifiers (diff) | |
| download | linux-0e91796eb46e29edc791131c832a2232bcaed9dd.tar.xz linux-0e91796eb46e29edc791131c832a2232bcaed9dd.zip | |
net: Fix call to ->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags()
Am I just being particularly dim today, or can the call to
dev->change_rx_flags(dev, IFF_MULTICAST) in dev_change_flags() never
happen?
We've just set dev->flags = flags & IFF_MULTICAST, effectively. So the
condition '(dev->flags ^ flags) & IFF_MULTICAST' is _never_ going to be
true.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index ce88c0d3e354..582963077877 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -3141,7 +3141,7 @@ int dev_change_flags(struct net_device *dev, unsigned flags) * Load in the correct multicast list now the flags have changed. */ - if (dev->change_rx_flags && (dev->flags ^ flags) & IFF_MULTICAST) + if (dev->change_rx_flags && (old_flags ^ flags) & IFF_MULTICAST) dev->change_rx_flags(dev, IFF_MULTICAST); dev_set_rx_mode(dev); |