summaryrefslogtreecommitdiffstats
path: root/net/core
diff options
context:
space:
mode:
authorEric Sesterhenn <snakebyte@gmx.de>2006-09-27 08:26:38 +0200
committerDavid S. Miller <davem@sunset.davemloft.net>2006-09-29 03:01:23 +0200
commit9918f230969bdaf3df012b77abcbcd4cdb0ab221 (patch)
tree8cad5227f352a2a0756b2978339eff4b0a5ba0cb /net/core
parent[SUNRPC]: more sunrpc endianness annotations (diff)
downloadlinux-9918f230969bdaf3df012b77abcbcd4cdb0ab221.tar.xz
linux-9918f230969bdaf3df012b77abcbcd4cdb0ab221.zip
[RTNETLINK]: Possible dereference in net/core/rtnetlink.c
another possible dereference spotted by coverity (#cid 1390). if the nlmsg_parse() call fails, we goto errout, where we call dev_put(), with dev still initialized to NULL. Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
-rw-r--r--net/core/rtnetlink.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index d8e25e08cb7e..221e4038216b 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -562,7 +562,7 @@ static int rtnl_getlink(struct sk_buff *skb, struct nlmsghdr* nlh, void *arg)
err = nlmsg_parse(nlh, sizeof(*ifm), tb, IFLA_MAX, ifla_policy);
if (err < 0)
- goto errout;
+ return err;
ifm = nlmsg_data(nlh);
if (ifm->ifi_index >= 0) {