diff options
| author | Alexander Stein <alexander.stein@systec-electronic.com> | 2015-09-28 15:05:33 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-09-29 23:56:20 +0200 |
| commit | 75c261b51ba19f0791de608f0acfb94956f78c76 (patch) | |
| tree | 9b35f0d5d33a6194789e27fcc667c0581ab67e60 /net/core | |
| parent | bna: fix error handling (diff) | |
| download | linux-75c261b51ba19f0791de608f0acfb94956f78c76.tar.xz linux-75c261b51ba19f0791de608f0acfb94956f78c76.zip | |
net sysfs: Print link speed as signed integer
Otherwise 4294967295 (MBit/s) (-1) will be printed when there is no link.
Documentation/ABI/testing/sysfs-class-net does not state if this shall be
signed or unsigned.
Also remove the now unused variable fmt_udec.
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/net-sysfs.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 805a95a48107..830f8a7c1cb1 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -31,7 +31,6 @@ static const char fmt_hex[] = "%#x\n"; static const char fmt_long_hex[] = "%#lx\n"; static const char fmt_dec[] = "%d\n"; -static const char fmt_udec[] = "%u\n"; static const char fmt_ulong[] = "%lu\n"; static const char fmt_u64[] = "%llu\n"; @@ -202,7 +201,7 @@ static ssize_t speed_show(struct device *dev, if (netif_running(netdev)) { struct ethtool_cmd cmd; if (!__ethtool_get_settings(netdev, &cmd)) - ret = sprintf(buf, fmt_udec, ethtool_cmd_speed(&cmd)); + ret = sprintf(buf, fmt_dec, ethtool_cmd_speed(&cmd)); } rtnl_unlock(); return ret; |