diff options
| author | Wei Yongjun <weiyongjun1@huawei.com> | 2017-12-27 10:05:52 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-01-02 19:48:29 +0100 |
| commit | 9540d977618c31586035870a56bd2d1cc2b4a9ba (patch) | |
| tree | bf212df68278a7556241877a3358df4aa0635f4c /net/dccp | |
| parent | cxgb4: use CLIP with LIP6 on T6 for TCAM filters (diff) | |
| download | linux-9540d977618c31586035870a56bd2d1cc2b4a9ba.tar.xz linux-9540d977618c31586035870a56bd2d1cc2b4a9ba.zip | |
net: sched: fix skb leak in dev_requeue_skb()
When dev_requeue_skb() is called with bulked skb list, only the
first skb of the list will be requeued to qdisc layer, and leak
the others without free them.
TCP is broken due to skb leak since no free skb will be considered
as still in the host queue and never be retransmitted. This happend
when dev_requeue_skb() called from qdisc_restart().
qdisc_restart
|-- dequeue_skb
|-- sch_direct_xmit()
|-- dev_requeue_skb() <-- skb may bluked
Fix dev_requeue_skb() to requeue the full bluked list. Also change
to use __skb_queue_tail() in __dev_requeue_skb() to avoid skb out
of order.
Fixes: a53851e2c321 ("net: sched: explicit locking in gso_cpu fallback")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dccp')
0 files changed, 0 insertions, 0 deletions