diff options
| author | Yajun Deng <yajun.deng@linux.dev> | 2021-07-29 09:13:50 +0200 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-07-30 15:33:24 +0200 |
| commit | 79976892f7ea37f44f8bcfb6d266954e8ae0124d (patch) | |
| tree | 9e438088b39b37c3f5cb1152cb59d284f9adaf8a /net/decnet | |
| parent | bcm63xx_enet: delete a redundant assignment (diff) | |
| download | linux-79976892f7ea37f44f8bcfb6d266954e8ae0124d.tar.xz linux-79976892f7ea37f44f8bcfb6d266954e8ae0124d.zip | |
net: convert fib_treeref from int to refcount_t
refcount_t type should be used instead of int when fib_treeref is used as
a reference counter,and avoid use-after-free risks.
Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20210729071350.28919-1-yajun.deng@linux.dev
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/decnet')
| -rw-r--r-- | net/decnet/dn_fib.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/net/decnet/dn_fib.c b/net/decnet/dn_fib.c index 77fbf8e9df4b..387a7e81dd00 100644 --- a/net/decnet/dn_fib.c +++ b/net/decnet/dn_fib.c @@ -102,7 +102,7 @@ void dn_fib_free_info(struct dn_fib_info *fi) void dn_fib_release_info(struct dn_fib_info *fi) { spin_lock(&dn_fib_info_lock); - if (fi && --fi->fib_treeref == 0) { + if (fi && refcount_dec_and_test(&fi->fib_treeref)) { if (fi->fib_next) fi->fib_next->fib_prev = fi->fib_prev; if (fi->fib_prev) @@ -385,11 +385,11 @@ link_it: if ((ofi = dn_fib_find_info(fi)) != NULL) { fi->fib_dead = 1; dn_fib_free_info(fi); - ofi->fib_treeref++; + refcount_inc(&ofi->fib_treeref); return ofi; } - fi->fib_treeref++; + refcount_inc(&fi->fib_treeref); refcount_set(&fi->fib_clntref, 1); spin_lock(&dn_fib_info_lock); fi->fib_next = dn_fib_info_list; |