diff options
| author | Jiri Pirko <jiri@mellanox.com> | 2019-03-28 13:56:44 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-03-28 20:55:31 +0100 |
| commit | d484210bf745ee6d8269b7d747bc5b94c4416ff1 (patch) | |
| tree | b9f3adc7268f2cc4db56bf583510628fa59f544a /net/dsa | |
| parent | dsa: implement ndo_get_devlink_port (diff) | |
| download | linux-d484210bf745ee6d8269b7d747bc5b94c4416ff1.tar.xz linux-d484210bf745ee6d8269b7d747bc5b94c4416ff1.zip | |
dsa: do not support ndo_get_phys_port_name for non-legacy ports
Since each non-legacy slave has its own devlink port instance
correctly set, rely on devlink core to generate correct phys port name.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa')
| -rw-r--r-- | net/dsa/slave.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/net/dsa/slave.c b/net/dsa/slave.c index d1a0a656b6b5..80be8e86c82d 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -736,6 +736,13 @@ static int dsa_slave_get_phys_port_name(struct net_device *dev, { struct dsa_port *dp = dsa_slave_to_port(dev); + /* For non-legacy ports, devlink is used and it takes + * care of the name generation. This ndo implementation + * should be removed with legacy support. + */ + if (dp->ds->devlink) + return -EOPNOTSUPP; + if (snprintf(name, len, "p%d", dp->index) >= len) return -EINVAL; |