summaryrefslogtreecommitdiffstats
path: root/net/ethernet
diff options
context:
space:
mode:
authorPatrick McHardy <kaber@trash.net>2008-04-14 07:45:40 +0200
committerDavid S. Miller <davem@davemloft.net>2008-04-14 07:45:40 +0200
commit2ed9926e16094ad143b96b09c64cba8bcba05ee1 (patch)
tree80694dbe8455fe47053709bd3c14a7edab1a8c24 /net/ethernet
parent[ISDN]: Do not validate ISDN net device address prior to interface-up (diff)
downloadlinux-2ed9926e16094ad143b96b09c64cba8bcba05ee1.tar.xz
linux-2ed9926e16094ad143b96b09c64cba8bcba05ee1.zip
[NET]: Return more appropriate error from eth_validate_addr().
Paul Bolle wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=9923 would have been much easier to > track down if eth_validate_addr() would somehow complain aloud if an address > is invalid. Shouldn't it make at least some noise? I guess it should return -EADDRNOTAVAIL similar to eth_mac_addr() when validation fails. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
-rw-r--r--net/ethernet/eth.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
index a7b417523e9b..a80839b02e3f 100644
--- a/net/ethernet/eth.c
+++ b/net/ethernet/eth.c
@@ -301,7 +301,7 @@ static int eth_change_mtu(struct net_device *dev, int new_mtu)
static int eth_validate_addr(struct net_device *dev)
{
if (!is_valid_ether_addr(dev->dev_addr))
- return -EINVAL;
+ return -EADDRNOTAVAIL;
return 0;
}