diff options
| author | David Ahern <dsahern@gmail.com> | 2018-10-24 21:59:01 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-10-24 23:06:25 +0200 |
| commit | ae677bbb4441309e1827e60413de92363153dccb (patch) | |
| tree | 098cb71d5990c8b8677194a3091a48a95437bcc4 /net/ipv4/fib_frontend.c | |
| parent | net/ipv6: Put target net when address dump fails due to bad attributes (diff) | |
| download | linux-ae677bbb4441309e1827e60413de92363153dccb.tar.xz linux-ae677bbb4441309e1827e60413de92363153dccb.zip | |
net: Don't return invalid table id error when dumping all families
When doing a route dump across all address families, do not error out
if the table does not exist. This allows a route dump for AF_UNSPEC
with a table id that may only exist for some of the families.
Do return the table does not exist error if dumping routes for a
specific family and the table does not exist.
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/fib_frontend.c')
| -rw-r--r-- | net/ipv4/fib_frontend.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index 5bf653f36911..6df95be96311 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -829,6 +829,7 @@ int ip_valid_fib_dump_req(struct net *net, const struct nlmsghdr *nlh, return -EINVAL; } + filter->dump_all_families = (rtm->rtm_family == AF_UNSPEC); filter->flags = rtm->rtm_flags; filter->protocol = rtm->rtm_protocol; filter->rt_type = rtm->rtm_type; @@ -899,6 +900,9 @@ static int inet_dump_fib(struct sk_buff *skb, struct netlink_callback *cb) if (filter.table_id) { tb = fib_get_table(net, filter.table_id); if (!tb) { + if (filter.dump_all_families) + return skb->len; + NL_SET_ERR_MSG(cb->extack, "ipv4: FIB table does not exist"); return -ENOENT; } |