diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-10-21 00:03:38 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-10-21 12:09:41 +0200 |
| commit | 9b0c290e78d667e6a483bde8c7cef7dd15f49017 (patch) | |
| tree | ed68f6cbcc9a512106217694b16a846147cdf54a /net/ipv4/fib_lookup.h | |
| parent | net/sched: fix missing spinlock init (diff) | |
| download | linux-9b0c290e78d667e6a483bde8c7cef7dd15f49017.tar.xz linux-9b0c290e78d667e6a483bde8c7cef7dd15f49017.zip | |
fib: introduce fib_alias_accessed() helper
Perf tools session at NFWS 2010 pointed out a false sharing on struct
fib_alias that can be avoided pretty easily, if we set FA_S_ACCESSED bit
only if needed (ie : not already set)
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/fib_lookup.h')
| -rw-r--r-- | net/ipv4/fib_lookup.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/net/ipv4/fib_lookup.h b/net/ipv4/fib_lookup.h index 5072d8effd5d..a29edf2219c8 100644 --- a/net/ipv4/fib_lookup.h +++ b/net/ipv4/fib_lookup.h @@ -17,6 +17,13 @@ struct fib_alias { #define FA_S_ACCESSED 0x01 +/* Dont write on fa_state unless needed, to keep it shared on all cpus */ +static inline void fib_alias_accessed(struct fib_alias *fa) +{ + if (!(fa->fa_state & FA_S_ACCESSED)) + fa->fa_state |= FA_S_ACCESSED; +} + /* Exported by fib_semantics.c */ extern int fib_semantic_match(struct list_head *head, const struct flowi *flp, |