diff options
| author | David S. Miller <davem@davemloft.net> | 2010-11-12 02:07:48 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-11-12 02:07:48 +0100 |
| commit | c753796769e4fb0cd813b6e5801b3c01f4681d4f (patch) | |
| tree | f137ec0b76593a2aa1a6a263bcc1e4cf82bdf7b5 /net/ipv4/icmp.c | |
| parent | Merge branch 'dccp' of git://eden-feed.erg.abdn.ac.uk/net-next-2.6 (diff) | |
| download | linux-c753796769e4fb0cd813b6e5801b3c01f4681d4f.tar.xz linux-c753796769e4fb0cd813b6e5801b3c01f4681d4f.zip | |
ipv4: Make rt->fl.iif tests lest obscure.
When we test rt->fl.iif against zero, we're seeing if it's
an output or an input route.
Make that explicit with some helper functions.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/icmp.c')
| -rw-r--r-- | net/ipv4/icmp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c index 96bc7f9475a3..c6e2affafbd3 100644 --- a/net/ipv4/icmp.c +++ b/net/ipv4/icmp.c @@ -506,8 +506,8 @@ void icmp_send(struct sk_buff *skb_in, int type, int code, __be32 info) struct net_device *dev = NULL; rcu_read_lock(); - if (rt->fl.iif && - net->ipv4.sysctl_icmp_errors_use_inbound_ifaddr) + if (rt_is_input_route(rt) && + net->ipv4.sysctl_icmp_errors_use_inbound_ifaddr) dev = dev_get_by_index_rcu(net, rt->fl.iif); if (dev) |