diff options
| author | David S. Miller <davem@davemloft.net> | 2011-04-26 22:57:47 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-04-27 22:59:05 +0200 |
| commit | 2e97e980b5653c23d01c911af6a0ab2d3431d7f1 (patch) | |
| tree | 03993cc582cc2ed1488aac7223205a11753d60df /net/ipv4/igmp.c | |
| parent | ipv4: Sanitize and simplify ip_route_{connect,newports}() (diff) | |
| download | linux-2e97e980b5653c23d01c911af6a0ab2d3431d7f1.tar.xz linux-2e97e980b5653c23d01c911af6a0ab2d3431d7f1.zip | |
ipv4: Remove erroneous check in igmpv3_newpack() and igmp_send_report().
Output route resolution never returns a route with rt_src set to zero
(which is INADDR_ANY).
Even if the flow key for the output route lookup specifies INADDR_ANY
for the source address, the output route resolution chooses a real
source address to use in the final route.
This test has existed forever in igmp_send_report() and David Stevens
simply copied over the erroneous test when implementing support for
IGMPv3.
Signed-off-by: David S. Miller <davem@davemloft.net>
Reviewed-by: Eric Dumazet <eric.dumazet@gmail.com>
Diffstat (limited to '')
| -rw-r--r-- | net/ipv4/igmp.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/net/ipv4/igmp.c b/net/ipv4/igmp.c index 1fd3d9ce8398..8ae0a5702f56 100644 --- a/net/ipv4/igmp.c +++ b/net/ipv4/igmp.c @@ -328,11 +328,6 @@ static struct sk_buff *igmpv3_newpack(struct net_device *dev, int size) kfree_skb(skb); return NULL; } - if (rt->rt_src == 0) { - kfree_skb(skb); - ip_rt_put(rt); - return NULL; - } skb_dst_set(skb, &rt->dst); skb->dev = dev; @@ -670,11 +665,6 @@ static int igmp_send_report(struct in_device *in_dev, struct ip_mc_list *pmc, if (IS_ERR(rt)) return -1; - if (rt->rt_src == 0) { - ip_rt_put(rt); - return -1; - } - skb = alloc_skb(IGMP_SIZE+LL_ALLOCATED_SPACE(dev), GFP_ATOMIC); if (skb == NULL) { ip_rt_put(rt); |