diff options
| author | Josef Bacik <jbacik@fb.com> | 2017-09-23 02:20:08 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-09-23 05:33:17 +0200 |
| commit | fbed24bcc69d3e48c5402c371f19f5c7688871e5 (patch) | |
| tree | d7ff42f5bdbdf81bdbdb2efa92674afcbf88fc4b /net/ipv4/inet_connection_sock.c | |
| parent | net: use inet6_rcv_saddr to compare sockets (diff) | |
| download | linux-fbed24bcc69d3e48c5402c371f19f5c7688871e5.tar.xz linux-fbed24bcc69d3e48c5402c371f19f5c7688871e5.zip | |
inet: fix improper empty comparison
When doing my reuseport rework I screwed up and changed a
if (hlist_empty(&tb->owners))
to
if (!hlist_empty(&tb->owners))
This is obviously bad as all of the reuseport/reuse logic was reversed,
which caused weird problems like allowing an ipv4 bind conflict if we
opened an ipv4 only socket on a port followed by an ipv6 only socket on
the same port.
Fixes: b9470c27607b ("inet: kill smallest_size and smallest_port")
Reported-by: Cole Robinson <crobinso@redhat.com>
Signed-off-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/inet_connection_sock.c')
| -rw-r--r-- | net/ipv4/inet_connection_sock.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c index a1bf30438bc5..c039c937ba90 100644 --- a/net/ipv4/inet_connection_sock.c +++ b/net/ipv4/inet_connection_sock.c @@ -321,7 +321,7 @@ tb_found: goto fail_unlock; } success: - if (!hlist_empty(&tb->owners)) { + if (hlist_empty(&tb->owners)) { tb->fastreuse = reuse; if (sk->sk_reuseport) { tb->fastreuseport = FASTREUSEPORT_ANY; |