diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2018-08-06 21:17:35 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-08-06 22:15:12 +0200 |
| commit | 70837ffe3085c9a91488b52ca13ac84424da1042 (patch) | |
| tree | 1b6d51608aef04b4722bd26772e85a574b7f366d /net/ipv4/ip_fragment.c | |
| parent | ptp_qoriq: use div_u64/div_u64_rem for 64-bit division (diff) | |
| download | linux-70837ffe3085c9a91488b52ca13ac84424da1042.tar.xz linux-70837ffe3085c9a91488b52ca13ac84424da1042.zip | |
ipv4: frags: precedence bug in ip_expire()
We accidentally removed the parentheses here, but they are required
because '!' has higher precedence than '&'.
Fixes: fa0f527358bd ("ip: use rb trees for IP frag queue.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_fragment.c')
| -rw-r--r-- | net/ipv4/ip_fragment.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c index 0e8f8de77e71..7cb7ed761d8c 100644 --- a/net/ipv4/ip_fragment.c +++ b/net/ipv4/ip_fragment.c @@ -154,7 +154,7 @@ static void ip_expire(struct timer_list *t) __IP_INC_STATS(net, IPSTATS_MIB_REASMFAILS); __IP_INC_STATS(net, IPSTATS_MIB_REASMTIMEOUT); - if (!qp->q.flags & INET_FRAG_FIRST_IN) + if (!(qp->q.flags & INET_FRAG_FIRST_IN)) goto out; /* sk_buff::dev and sk_buff::rbnode are unionized. So we |