diff options
author | Florian Westphal <fw@strlen.de> | 2014-07-24 16:50:36 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2014-07-28 07:34:36 +0200 |
commit | ab1c724f633080ed2e8a0cfe61654599b55cf8f9 (patch) | |
tree | 215b28da3dc0fbbac8dd853501306f65b165a499 /net/ipv4/ip_fragment.c | |
parent | inet: frag: remove periodic secret rebuild timer (diff) | |
download | linux-ab1c724f633080ed2e8a0cfe61654599b55cf8f9.tar.xz linux-ab1c724f633080ed2e8a0cfe61654599b55cf8f9.zip |
inet: frag: use seqlock for hash rebuild
rehash is rare operation, don't force readers to take
the read-side rwlock.
Instead, we only have to detect the (rare) case where
the secret was altered while we are trying to insert
a new inetfrag queue into the table.
If it was changed, drop the bucket lock and recompute
the hash to get the 'new' chain bucket that we have to
insert into.
Joint work with Nikolay Aleksandrov.
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Nikolay Aleksandrov <nikolay@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_fragment.c')
-rw-r--r-- | net/ipv4/ip_fragment.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/ipv4/ip_fragment.c b/net/ipv4/ip_fragment.c index 44e591a7e03f..ccee68dffd6e 100644 --- a/net/ipv4/ip_fragment.c +++ b/net/ipv4/ip_fragment.c @@ -244,7 +244,6 @@ static inline struct ipq *ip_find(struct net *net, struct iphdr *iph, u32 user) arg.iph = iph; arg.user = user; - read_lock(&ip4_frags.lock); hash = ipqhashfn(iph->id, iph->saddr, iph->daddr, iph->protocol); q = inet_frag_find(&net->ipv4.frags, &ip4_frags, &arg, hash); |