summaryrefslogtreecommitdiffstats
path: root/net/ipv4/ip_sockglue.c
diff options
context:
space:
mode:
authorYuval Mintz <Yuval.Mintz@qlogic.com>2015-03-23 09:56:14 +0100
committerDavid S. Miller <davem@davemloft.net>2015-03-24 03:38:24 +0100
commitdff173de84958a677ce0d24b1da3cdc3a32b4238 (patch)
tree0b69f6fbf728fb82dbf311c9b8bfc0ddaa2601b3 /net/ipv4/ip_sockglue.c
parentMerge tag 'linux-can-fixes-for-4.0-20150322' of git://git.kernel.org/pub/scm/... (diff)
downloadlinux-dff173de84958a677ce0d24b1da3cdc3a32b4238.tar.xz
linux-dff173de84958a677ce0d24b1da3cdc3a32b4238.zip
bnx2x: Fix statistics locking scheme
Statistics' state-machine in bnx2x driver must be synced with various driver flows, but its current locking scheme manages to be wasteful [using 2 locks + additional local variable] and prone to race-conditions at the same time, as the state-machine and 'action' are being accessed under different locks. In addition, current 'safe exec' isn't in fact safe, since the only guarantee it gives is that DMA transactions are over, but ramrods might still be running. This patch cleans up said logic, leaving us with a single lock for the entire flow and removing the possible races. Changes from v2: - Switched into mutex locking from semaphore locking. - Release locks on error flows. Changes from v1: Failure to acquire lock fails flow instead of printing a warning and allowing access to the critical section. Signed-off-by: Yuval Mintz <Yuval.Mintz@qlogic.com> Signed-off-by: Ariel Elior <Ariel.Elior@qlogic.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_sockglue.c')
0 files changed, 0 insertions, 0 deletions