diff options
| author | Eric Dumazet <edumazet@google.com> | 2023-07-28 17:03:18 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-07-29 19:13:41 +0200 |
| commit | 8bf43be799d4b242ea552a14db10456446be843e (patch) | |
| tree | e022e5d483cebc0f7a62f89b4095e07ab58ed599 /net/ipv4/ip_sockglue.c | |
| parent | net: add missing data-race annotation for sk_ll_usec (diff) | |
| download | linux-8bf43be799d4b242ea552a14db10456446be843e.tar.xz linux-8bf43be799d4b242ea552a14db10456446be843e.zip | |
net: annotate data-races around sk->sk_priority
sk_getsockopt() runs locklessly. This means sk->sk_priority
can be read while other threads are changing its value.
Other reads also happen without socket lock being held.
Add missing annotations where needed.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/ip_sockglue.c')
| -rw-r--r-- | net/ipv4/ip_sockglue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c index 8e97d8d4cc9d..d41bce8927b2 100644 --- a/net/ipv4/ip_sockglue.c +++ b/net/ipv4/ip_sockglue.c @@ -592,7 +592,7 @@ void __ip_sock_set_tos(struct sock *sk, int val) } if (inet_sk(sk)->tos != val) { inet_sk(sk)->tos = val; - sk->sk_priority = rt_tos2priority(val); + WRITE_ONCE(sk->sk_priority, rt_tos2priority(val)); sk_dst_reset(sk); } } |