diff options
| author | David Ahern <dsahern@gmail.com> | 2020-05-17 19:26:32 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-05-17 19:41:24 +0200 |
| commit | 84be69b869a5a496a6cfde9b3c29509207a1f1fa (patch) | |
| tree | c57fe1a4c4fd1ec6ca07d596eb83b47dd975d5dd /net/ipv4/nexthop.c | |
| parent | net: ipa: don't be a hog in gsi_channel_poll() (diff) | |
| download | linux-84be69b869a5a496a6cfde9b3c29509207a1f1fa.tar.xz linux-84be69b869a5a496a6cfde9b3c29509207a1f1fa.zip | |
nexthop: Fix attribute checking for groups
For nexthop groups, attributes after NHA_GROUP_TYPE are invalid, but
nh_check_attr_group starts checking at NHA_GROUP. The group type defaults
to multipath and the NHA_GROUP_TYPE is currently optional so this has
slipped through so far. Fix the attribute checking to handle support of
new group types.
Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
Signed-off-by: ASSOGBA Emery <assogba.emery@gmail.com>
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to '')
| -rw-r--r-- | net/ipv4/nexthop.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c index fdfca534d094..2a31c4af845e 100644 --- a/net/ipv4/nexthop.c +++ b/net/ipv4/nexthop.c @@ -433,7 +433,7 @@ static int nh_check_attr_group(struct net *net, struct nlattr *tb[], if (!valid_group_nh(nh, len, extack)) return -EINVAL; } - for (i = NHA_GROUP + 1; i < __NHA_MAX; ++i) { + for (i = NHA_GROUP_TYPE + 1; i < __NHA_MAX; ++i) { if (!tb[i]) continue; |