diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2018-01-10 21:21:31 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-01-15 19:45:03 +0100 |
| commit | 28b2e0d2cd132284ad69fcea4b7cf6b7d0662c2f (patch) | |
| tree | 78f7165cb7332eafcc5269525f01416de38683d9 /net/ipv4/tcp_metrics.c | |
| parent | tipc: fix a potental access after delete in tipc_sk_join() (diff) | |
| download | linux-28b2e0d2cd132284ad69fcea4b7cf6b7d0662c2f.tar.xz linux-28b2e0d2cd132284ad69fcea4b7cf6b7d0662c2f.zip | |
net: phy: remove parameter new_link from phy_mac_interrupt()
I see two issues with parameter new_link:
1. It's not needed. See also phy_interrupt(), works w/o this parameter.
phy_mac_interrupt sets the state to PHY_CHANGELINK and triggers the
state machine which then calls phy_read_status. And phy_read_status
updates the link state.
2. phy_mac_interrupt is used in interrupt context and getting the link
state may sleep (at least when having to access the PHY registers
via MDIO bus).
So let's remove it.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_metrics.c')
0 files changed, 0 insertions, 0 deletions