diff options
| author | Hua Zhong <hzhong@gmail.com> | 2006-04-29 00:26:50 +0200 |
|---|---|---|
| committer | David S. Miller <davem@sunset.davemloft.net> | 2006-04-30 03:33:19 +0200 |
| commit | 83de47cd0c5738105f40e65191b0761dfa7431ac (patch) | |
| tree | c519837e16dfaf3dd35f2454e6e969d6a47a27e1 /net/ipv4/tcp_output.c | |
| parent | [XFRM]: fix softirq-unsafe xfrm typemap->lock use (diff) | |
| download | linux-83de47cd0c5738105f40e65191b0761dfa7431ac.tar.xz linux-83de47cd0c5738105f40e65191b0761dfa7431ac.zip | |
[TCP]: Fix unlikely usage in tcp_transmit_skb()
The following unlikely should be replaced by likely because the
condition happens every time unless there is a hard error to transmit
a packet.
Signed-off-by: Hua Zhong <hzhong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_output.c')
| -rw-r--r-- | net/ipv4/tcp_output.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index a28ae593b976..743016baa048 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp_output.c @@ -465,7 +465,7 @@ static int tcp_transmit_skb(struct sock *sk, struct sk_buff *skb, int clone_it, TCP_INC_STATS(TCP_MIB_OUTSEGS); err = icsk->icsk_af_ops->queue_xmit(skb, 0); - if (unlikely(err <= 0)) + if (likely(err <= 0)) return err; tcp_enter_cwr(sk); |