diff options
| author | David S. Miller <davem@davemloft.net> | 2005-07-08 23:57:23 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2005-07-08 23:57:23 +0200 |
| commit | b03efcfb2180289718991bb984044ce6c5b7d1b0 (patch) | |
| tree | f3b0c6c4eaf0991c28b7116a20994b48398eea57 /net/ipv4/tcp_timer.c | |
| parent | [PATCH] Add MAINTAINERS entry for audit subsystem (diff) | |
| download | linux-b03efcfb2180289718991bb984044ce6c5b7d1b0.tar.xz linux-b03efcfb2180289718991bb984044ce6c5b7d1b0.zip | |
[NET]: Transform skb_queue_len() binary tests into skb_queue_empty()
This is part of the grand scheme to eliminate the qlen
member of skb_queue_head, and subsequently remove the
'list' member of sk_buff.
Most users of skb_queue_len() want to know if the queue is
empty or not, and that's trivially done with skb_queue_empty()
which doesn't use the skb_queue_head->qlen member and instead
uses the queue list emptyness as the test.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_timer.c')
| -rw-r--r-- | net/ipv4/tcp_timer.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/net/ipv4/tcp_timer.c b/net/ipv4/tcp_timer.c index b127b4498565..0084227438c2 100644 --- a/net/ipv4/tcp_timer.c +++ b/net/ipv4/tcp_timer.c @@ -231,11 +231,10 @@ static void tcp_delack_timer(unsigned long data) } tp->ack.pending &= ~TCP_ACK_TIMER; - if (skb_queue_len(&tp->ucopy.prequeue)) { + if (!skb_queue_empty(&tp->ucopy.prequeue)) { struct sk_buff *skb; - NET_ADD_STATS_BH(LINUX_MIB_TCPSCHEDULERFAILED, - skb_queue_len(&tp->ucopy.prequeue)); + NET_INC_STATS_BH(LINUX_MIB_TCPSCHEDULERFAILED); while ((skb = __skb_dequeue(&tp->ucopy.prequeue)) != NULL) sk->sk_backlog_rcv(sk, skb); |