diff options
| author | Eric Dumazet <dada1@cosmosbay.com> | 2008-11-25 00:52:46 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-11-25 00:52:46 +0100 |
| commit | 2e77d89b2fa8e3f8325b8ce7893ec3645f41aff5 (patch) | |
| tree | ae40aa75449f705bd166630f9bcb5f41373d8248 /net/ipv4/udp.c | |
| parent | net: gen_estimator: Fix gen_kill_estimator() lookups (diff) | |
| download | linux-2e77d89b2fa8e3f8325b8ce7893ec3645f41aff5.tar.xz linux-2e77d89b2fa8e3f8325b8ce7893ec3645f41aff5.zip | |
net: avoid a pair of dst_hold()/dst_release() in ip_append_data()
We can reduce pressure on dst entry refcount that slowdown UDP transmit
path on SMP machines. This pressure is visible on RTP servers when
delivering content to mediagateways, especially big ones, handling
thousand of streams. Several cpus send UDP frames to the same
destination, hence use the same dst entry.
This patch makes ip_append_data() eventually steal the refcount its
callers had to take on the dst entry.
This doesnt avoid all refcounting, but still gives speedups on SMP,
on UDP/RAW transmit path
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/udp.c')
| -rw-r--r-- | net/ipv4/udp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index da869ce041d9..549114472db3 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -719,7 +719,7 @@ do_append_data: up->len += ulen; getfrag = is_udplite ? udplite_getfrag : ip_generic_getfrag; err = ip_append_data(sk, getfrag, msg->msg_iov, ulen, - sizeof(struct udphdr), &ipc, rt, + sizeof(struct udphdr), &ipc, &rt, corkreq ? msg->msg_flags|MSG_MORE : msg->msg_flags); if (err) udp_flush_pending_frames(sk); |