diff options
| author | Anders Larsen <al@alarsen.net> | 2013-08-18 11:54:40 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-08-21 00:05:04 +0200 |
| commit | c196ce05cfdb7b5a8af12a3096fac9e880d59617 (patch) | |
| tree | a70f95ec53093a755910716f3626560eea89b331 /net/ipv4 | |
| parent | moxa: fix missing unlock on error in moxart_mac_start_xmit() (diff) | |
| download | linux-c196ce05cfdb7b5a8af12a3096fac9e880d59617.tar.xz linux-c196ce05cfdb7b5a8af12a3096fac9e880d59617.zip | |
pch_gbe: ethtool cannot change parameters when link is down
When attempting to change e.g. the advertising mask when the link is down
ecmd->speed is -1 causing mii_ethtool_sset() to bail out.
This bug bit when connecting to a gigabit switch through a 4-pin (industrial)
cable, since link negotiation would not complete (both endpoints claimed to
be gigabit-capable, but this is not possible with only 4 pins).
Any attempt to fix this by setting autonegation to not offer 1000Mbps
failed as the setting would not be accepted while the link was still down...
Set ecmd->speed to SPEED_1000 to satisfy mii_ethtool_sset()
(the actual value of ecmd->speed doesn't matter as long as it is valid,
since a re-negotation is forced afterwards).
Signed-off-by: Anders Larsen <al@alarsen.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
0 files changed, 0 insertions, 0 deletions