diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2009-10-30 06:03:53 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2009-10-30 20:25:12 +0100 |
commit | 9d410c796067686b1e032d54ce475b7055537138 (patch) | |
tree | 4442bdbe4a4be1cce024f2e83a12b7404ef935fa /net/ipv4 | |
parent | pcnet_cs: add cis of PreMax PE-200 ethernet pcmcia card (diff) | |
download | linux-9d410c796067686b1e032d54ce475b7055537138.tar.xz linux-9d410c796067686b1e032d54ce475b7055537138.zip |
net: fix sk_forward_alloc corruption
On UDP sockets, we must call skb_free_datagram() with socket locked,
or risk sk_forward_alloc corruption. This requirement is not respected
in SUNRPC.
Add a convenient helper, skb_free_datagram_locked() and use it in SUNRPC
Reported-by: Francis Moreau <francis.moro@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4')
-rw-r--r-- | net/ipv4/udp.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index d0d436d6216c..0fa9f70e4b19 100644 --- a/net/ipv4/udp.c +++ b/net/ipv4/udp.c @@ -999,9 +999,7 @@ try_again: err = ulen; out_free: - lock_sock(sk); - skb_free_datagram(sk, skb); - release_sock(sk); + skb_free_datagram_locked(sk, skb); out: return err; |