diff options
| author | Eric Dumazet <edumazet@google.com> | 2024-02-22 13:17:47 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-02-26 12:56:23 +0100 |
| commit | 10bfd453da64a057bcfd1a49fb6b271c48653cdb (patch) | |
| tree | c2e9d1e810ca54d41998a0ea1f7bcea3aa5be0bb /net/ipv6/addrconf.c | |
| parent | selftests: net: veth: test syncing GRO and XDP state while device is down (diff) | |
| download | linux-10bfd453da64a057bcfd1a49fb6b271c48653cdb.tar.xz linux-10bfd453da64a057bcfd1a49fb6b271c48653cdb.zip | |
ipv6: fix potential "struct net" leak in inet6_rtm_getaddr()
It seems that if userspace provides a correct IFA_TARGET_NETNSID value
but no IFA_ADDRESS and IFA_LOCAL attributes, inet6_rtm_getaddr()
returns -EINVAL with an elevated "struct net" refcount.
Fixes: 6ecf4c37eb3e ("ipv6: enable IFA_TARGET_NETNSID for RTM_GETADDR")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Christian Brauner <brauner@kernel.org>
Cc: David Ahern <dsahern@kernel.org>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/addrconf.c')
| -rw-r--r-- | net/ipv6/addrconf.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 5a839c5fb1a5..055230b669cf 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -5509,9 +5509,10 @@ static int inet6_rtm_getaddr(struct sk_buff *in_skb, struct nlmsghdr *nlh, } addr = extract_addr(tb[IFA_ADDRESS], tb[IFA_LOCAL], &peer); - if (!addr) - return -EINVAL; - + if (!addr) { + err = -EINVAL; + goto errout; + } ifm = nlmsg_data(nlh); if (ifm->ifa_index) dev = dev_get_by_index(tgt_net, ifm->ifa_index); |