diff options
| author | Wei Wang <weiwan@google.com> | 2017-10-06 21:06:05 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-10-07 22:22:58 +0200 |
| commit | 51e398e86d61b69b9a4be49ff7f6afeb87530df1 (patch) | |
| tree | b37f6853d0bdedc6a46cd44d1f2484208ace1ca5 /net/ipv6/ip6_fib.c | |
| parent | ipv6: grab rt->rt6i_ref before allocating pcpu rt (diff) | |
| download | linux-51e398e86d61b69b9a4be49ff7f6afeb87530df1.tar.xz linux-51e398e86d61b69b9a4be49ff7f6afeb87530df1.zip | |
ipv6: don't release rt->rt6i_pcpu memory during rt6_release()
After rwlock is replaced with rcu and spinlock, route lookup can happen
simultanously with route deletion.
This patch removes the call to free_percpu(rt->rt6i_pcpu) from
rt6_release() to avoid the race condition between rt6_release() and
rt6_get_pcpu_route(). And as free_percpu(rt->rt6i_pcpu) is already
called in ip6_dst_destroy() after the rcu grace period, it is safe to do
this change.
Signed-off-by: Wei Wang <weiwan@google.com>
Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6_fib.c')
| -rw-r--r-- | net/ipv6/ip6_fib.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c index 9c8e704e6af7..eee392f7b1f6 100644 --- a/net/ipv6/ip6_fib.c +++ b/net/ipv6/ip6_fib.c @@ -190,9 +190,6 @@ void rt6_free_pcpu(struct rt6_info *non_pcpu_rt) *ppcpu_rt = NULL; } } - - free_percpu(non_pcpu_rt->rt6i_pcpu); - non_pcpu_rt->rt6i_pcpu = NULL; } EXPORT_SYMBOL_GPL(rt6_free_pcpu); |