diff options
| author | Wei Yongjun <yjwei@cn.fujitsu.com> | 2009-02-23 22:45:33 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-02-25 08:33:52 +0100 |
| commit | 800d55f146098c5ffd1914d7eef2fd4a6d558b1d (patch) | |
| tree | ced8debeb88c78eb677c7842ea312be09caf21de /net/ipv6/ipv6_sockglue.c | |
| parent | netlink: change nlmsg_notify() return value logic (diff) | |
| download | linux-800d55f146098c5ffd1914d7eef2fd4a6d558b1d.tar.xz linux-800d55f146098c5ffd1914d7eef2fd4a6d558b1d.zip | |
ipv6: Remove some pointless conditionals before kfree_skb()
Remove some pointless conditionals before kfree_skb().
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression E;
@@
- if (E)
- kfree_skb(E);
+ kfree_skb(E);
// </smpl>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ipv6_sockglue.c')
| -rw-r--r-- | net/ipv6/ipv6_sockglue.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/ipv6/ipv6_sockglue.c b/net/ipv6/ipv6_sockglue.c index 40f324655e24..d31df0f4bc9a 100644 --- a/net/ipv6/ipv6_sockglue.c +++ b/net/ipv6/ipv6_sockglue.c @@ -218,8 +218,7 @@ static int do_ipv6_setsockopt(struct sock *sk, int level, int optname, if (opt) sock_kfree_s(sk, opt, opt->tot_len); pktopt = xchg(&np->pktoptions, NULL); - if (pktopt) - kfree_skb(pktopt); + kfree_skb(pktopt); sk->sk_destruct = inet_sock_destruct; /* |