diff options
| author | Eric Dumazet <edumazet@google.com> | 2024-02-28 14:54:28 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2024-03-01 09:42:31 +0100 |
| commit | e7135f484994494a38071e3653a83d21d305f50c (patch) | |
| tree | 734c791bf55fa4646d61929ada3684bc5de0791f /net/ipv6/ndisc.c | |
| parent | ipv6: addrconf_disable_ipv6() optimization (diff) | |
| download | linux-e7135f484994494a38071e3653a83d21d305f50c.tar.xz linux-e7135f484994494a38071e3653a83d21d305f50c.zip | |
ipv6: annotate data-races around cnf.mtu6
idev->cnf.mtu6 might be read locklessly, add appropriate READ_ONCE()
and WRITE_ONCE() annotations.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ndisc.c')
| -rw-r--r-- | net/ipv6/ndisc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index 8523f0595b01..e96d79cd34d2 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c @@ -1578,8 +1578,8 @@ skip_routeinfo: if (mtu < IPV6_MIN_MTU || mtu > skb->dev->mtu) { ND_PRINTK(2, warn, "RA: invalid mtu: %d\n", mtu); - } else if (in6_dev->cnf.mtu6 != mtu) { - in6_dev->cnf.mtu6 = mtu; + } else if (READ_ONCE(in6_dev->cnf.mtu6) != mtu) { + WRITE_ONCE(in6_dev->cnf.mtu6, mtu); fib6_metric_set(rt, RTAX_MTU, mtu); rt6_mtu_change(skb->dev, mtu); } |