diff options
| author | Wei Yongjun <yjwei@cn.fujitsu.com> | 2009-02-23 22:45:33 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-02-25 08:33:52 +0100 |
| commit | 800d55f146098c5ffd1914d7eef2fd4a6d558b1d (patch) | |
| tree | ced8debeb88c78eb677c7842ea312be09caf21de /net/ipv6/tcp_ipv6.c | |
| parent | netlink: change nlmsg_notify() return value logic (diff) | |
| download | linux-800d55f146098c5ffd1914d7eef2fd4a6d558b1d.tar.xz linux-800d55f146098c5ffd1914d7eef2fd4a6d558b1d.zip | |
ipv6: Remove some pointless conditionals before kfree_skb()
Remove some pointless conditionals before kfree_skb().
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
expression E;
@@
- if (E)
- kfree_skb(E);
+ kfree_skb(E);
// </smpl>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/tcp_ipv6.c')
| -rw-r--r-- | net/ipv6/tcp_ipv6.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c index 00f1269e11e9..4b5aa1854260 100644 --- a/net/ipv6/tcp_ipv6.c +++ b/net/ipv6/tcp_ipv6.c @@ -533,8 +533,7 @@ static inline void syn_flood_warning(struct sk_buff *skb) static void tcp_v6_reqsk_destructor(struct request_sock *req) { - if (inet6_rsk(req)->pktopts) - kfree_skb(inet6_rsk(req)->pktopts); + kfree_skb(inet6_rsk(req)->pktopts); } #ifdef CONFIG_TCP_MD5SIG @@ -1611,8 +1610,7 @@ ipv6_pktoptions: } } - if (opt_skb) - kfree_skb(opt_skb); + kfree_skb(opt_skb); return 0; } |