diff options
| author | Julia Lawall <julia@diku.dk> | 2010-05-26 07:56:48 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-05-27 06:09:51 +0200 |
| commit | a56635a56f2afb3d22d9ce07e8f8d69537416b2d (patch) | |
| tree | 96ff391bccbc702cf2c9d74eecb055c32fb59a49 /net/iucv/af_iucv.c | |
| parent | net: ll_temac: fix checksum offload logic (diff) | |
| download | linux-a56635a56f2afb3d22d9ce07e8f8d69537416b2d.tar.xz linux-a56635a56f2afb3d22d9ce07e8f8d69537416b2d.zip | |
net/iucv: Add missing spin_unlock
Add a spin_unlock missing on the error path. There seems like no reason
why the lock should continue to be held if the kzalloc fail.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression E1;
@@
* spin_lock(E1,...);
<+... when != E1
if (...) {
... when != E1
* return ...;
}
...+>
* spin_unlock(E1,...);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/iucv/af_iucv.c')
| -rw-r--r-- | net/iucv/af_iucv.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c index c8b4599a752e..9637e45744fa 100644 --- a/net/iucv/af_iucv.c +++ b/net/iucv/af_iucv.c @@ -1619,7 +1619,7 @@ static void iucv_callback_rx(struct iucv_path *path, struct iucv_message *msg) save_message: save_msg = kzalloc(sizeof(struct sock_msg_q), GFP_ATOMIC | GFP_DMA); if (!save_msg) - return; + goto out_unlock; save_msg->path = path; save_msg->msg = *msg; |