diff options
| author | Tom Parkin <tparkin@katalix.com> | 2020-07-23 13:29:50 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-07-23 20:54:40 +0200 |
| commit | 0febc7b3cd17bd2323a036356c2ae6514acf9010 (patch) | |
| tree | f6ab4f820da4a733104e35cbf66134c0dd0ca07f /net/l2tp/l2tp_ip6.c | |
| parent | net/ncsi: use eth_zero_addr() to clear mac address (diff) | |
| download | linux-0febc7b3cd17bd2323a036356c2ae6514acf9010.tar.xz linux-0febc7b3cd17bd2323a036356c2ae6514acf9010.zip | |
l2tp: cleanup comparisons to NULL
checkpatch warns about comparisons to NULL, e.g.
CHECK: Comparison to NULL could be written "!rt"
#474: FILE: net/l2tp/l2tp_ip.c:474:
+ if (rt == NULL) {
These sort of comparisons are generally clearer and more readable
the way checkpatch suggests, so update l2tp accordingly.
Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/l2tp/l2tp_ip6.c')
| -rw-r--r-- | net/l2tp/l2tp_ip6.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/l2tp/l2tp_ip6.c b/net/l2tp/l2tp_ip6.c index ca7696147c7e..614febf8dd0d 100644 --- a/net/l2tp/l2tp_ip6.c +++ b/net/l2tp/l2tp_ip6.c @@ -486,7 +486,7 @@ static int l2tp_ip6_push_pending_frames(struct sock *sk) int err = 0; skb = skb_peek(&sk->sk_write_queue); - if (skb == NULL) + if (!skb) goto out; transhdr = (__be32 *)skb_transport_header(skb); |