diff options
| author | Al Viro <viro@ZenIV.linux.org.uk> | 2011-06-05 02:54:03 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-06-05 23:11:09 +0200 |
| commit | b8f07a063163f8216cd891c5b007e839a56b6d93 (patch) | |
| tree | 83cd31339371ab707d29e1275633baf4d3db2a65 /net/l2tp | |
| parent | get_net_ns_by_fd() oopses if proc_ns_fget() returns an error (diff) | |
| download | linux-b8f07a063163f8216cd891c5b007e839a56b6d93.tar.xz linux-b8f07a063163f8216cd891c5b007e839a56b6d93.zip | |
fix return values of l2tp_dfs_seq_open()
More fallout from struct net lifetime rules review: PTR_ERR() is *already*
negative and failing ->open() should return negatives on failure.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: James Chapman <jchapman@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/l2tp')
| -rw-r--r-- | net/l2tp/l2tp_debugfs.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/l2tp/l2tp_debugfs.c b/net/l2tp/l2tp_debugfs.c index b8dbae82fab8..76130134bfa6 100644 --- a/net/l2tp/l2tp_debugfs.c +++ b/net/l2tp/l2tp_debugfs.c @@ -258,7 +258,7 @@ static int l2tp_dfs_seq_open(struct inode *inode, struct file *file) */ pd->net = get_net_ns_by_pid(current->pid); if (IS_ERR(pd->net)) { - rc = -PTR_ERR(pd->net); + rc = PTR_ERR(pd->net); goto err_free_pd; } |