diff options
| author | Kangjie Lu <kangjielu@gmail.com> | 2016-05-03 22:35:05 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-05-04 22:18:48 +0200 |
| commit | b8670c09f37bdf2847cc44f36511a53afc6161fd (patch) | |
| tree | 30c2e57ee6f84f58c04ca3e3c440a0ec2a3dd9c1 /net/llc | |
| parent | net: fec: only clear a queue's work bit if the queue was emptied (diff) | |
| download | linux-b8670c09f37bdf2847cc44f36511a53afc6161fd.tar.xz linux-b8670c09f37bdf2847cc44f36511a53afc6161fd.zip | |
net: fix infoleak in llc
The stack object “info” has a total size of 12 bytes. Its last byte
is padding which is not initialized and leaked via “put_cmsg”.
Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/llc')
| -rw-r--r-- | net/llc/af_llc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c index b3c52e3f689a..8ae3ed97d95c 100644 --- a/net/llc/af_llc.c +++ b/net/llc/af_llc.c @@ -626,6 +626,7 @@ static void llc_cmsg_rcv(struct msghdr *msg, struct sk_buff *skb) if (llc->cmsg_flags & LLC_CMSG_PKTINFO) { struct llc_pktinfo info; + memset(&info, 0, sizeof(info)); info.lpi_ifindex = llc_sk(skb->sk)->dev->ifindex; llc_pdu_decode_dsap(skb, &info.lpi_sap); llc_pdu_decode_da(skb, info.lpi_mac); |