diff options
| author | Emmanuel Grumbach <emmanuel.grumbach@intel.com> | 2015-01-22 22:32:46 +0100 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2015-01-23 10:54:22 +0100 |
| commit | 4afaff176a968457df18eeebc1aad910b6154761 (patch) | |
| tree | b72d595e376af86d6e3217a5d608fb690864cec2 /net/mac80211/iface.c | |
| parent | mac80211: synchronize_net() before flushing the queues (diff) | |
| download | linux-4afaff176a968457df18eeebc1aad910b6154761.tar.xz linux-4afaff176a968457df18eeebc1aad910b6154761.zip | |
mac80211: avoid races related to suspend flow
When we go to suspend, there is complex set of states that
avoids races. The quiescing variable is set whlie
__ieee80211_suspend is running. Then suspended is set.
The code makes sure there is no window without any of these
flags.
The problem is that workers can still be enqueued while we
are quiescing. This leads to situations where the driver is
already suspending and other flows like disassociation are
handled by a worker.
To fix this, we need to check quiescing and suspended flags
in the worker itself and not only before enqueueing it.
I also add here extensive documentation to ease the
understanding of these complex issues.
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/mac80211/iface.c')
| -rw-r--r-- | net/mac80211/iface.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 4371c123a95e..81a27516813e 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c @@ -1170,12 +1170,7 @@ static void ieee80211_iface_work(struct work_struct *work) if (local->scanning) return; - /* - * ieee80211_queue_work() should have picked up most cases, - * here we'll pick the rest. - */ - if (WARN(local->suspended, - "interface work scheduled while going to suspend\n")) + if (!ieee80211_can_run_worker(local)) return; /* first process frames */ |