diff options
author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-01-06 19:54:29 +0100 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2011-01-06 19:54:29 +0100 |
commit | 2c6607c611cb7bf0a6750bcea34a258144e302c5 (patch) | |
tree | 38156d2a938e5f346d7c4464e132132f7279dcba /net/mac80211/led.c | |
parent | af_unix: Avoid socket->sk NULL OOPS in stream connect security hooks. (diff) | |
download | linux-2c6607c611cb7bf0a6750bcea34a258144e302c5.tar.xz linux-2c6607c611cb7bf0a6750bcea34a258144e302c5.zip |
net: add POLLPRI to sock_def_readable()
Leonardo Chiquitto found poll() could block forever on tcp sockets and
Urgent data was received, if the event flag only contains POLLPRI.
He did a bisection and found commit 4938d7e0233 (poll: avoid extra
wakeups in select/poll) was the source of the problem.
Problem is TCP sockets use standard sock_def_readable() function for
their sk_data_ready() handler, and sock_def_readable() doesnt signal
POLLPRI.
Only TCP is affected by the problem. Adding POLLPRI to the list of flags
might trigger unnecessary schedules, but URGENT handling is such a
seldom used feature this seems a good compromise.
Thanks a lot to Leonardo for providing the bisection result and a test
program as well.
Reference : http://www.spinics.net/lists/netdev/msg151793.html
Reported-and-bisected-by: Leonardo Chiquitto <leonardo.lists@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Tested-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/mac80211/led.c')
0 files changed, 0 insertions, 0 deletions