diff options
| author | Marc Zyngier <marc.zyngier@arm.com> | 2018-08-24 17:06:37 +0200 |
|---|---|---|
| committer | Olof Johansson <olof@lixom.net> | 2018-08-24 17:50:32 +0200 |
| commit | 1aa55ca9b14af6cfd987ce4fdaf548f7067a5d07 (patch) | |
| tree | befb285272e15e7e782a146ad853667ba7c4fab4 /net/mac80211/main.c | |
| parent | iommu/rockchip: Handle errors returned from PM framework (diff) | |
| download | linux-1aa55ca9b14af6cfd987ce4fdaf548f7067a5d07.tar.xz linux-1aa55ca9b14af6cfd987ce4fdaf548f7067a5d07.zip | |
iommu/rockchip: Move irq request past pm_runtime_enable
Enabling the interrupt early, before power has been applied to the
device, can result in an interrupt being delivered too early if:
- the IOMMU shares an interrupt with a VOP
- the VOP has a pending interrupt (after a kexec, for example)
In these conditions, we end-up taking the interrupt without
the IOMMU being ready to handle the interrupt (not powered on).
Moving the interrupt request past the pm_runtime_enable() call
makes sure we can at least access the IOMMU registers. Note that
this is only a partial fix, and that the VOP interrupt will still
be screaming until the VOP driver kicks in, which advocates for
a more synchronized interrupt enabling/disabling approach.
Fixes: 0f181d3cf7d98 ("iommu/rockchip: Add runtime PM support")
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
Diffstat (limited to 'net/mac80211/main.c')
0 files changed, 0 insertions, 0 deletions