diff options
| author | Johannes Berg <johannes.berg@intel.com> | 2024-01-11 17:17:44 +0100 |
|---|---|---|
| committer | Johannes Berg <johannes.berg@intel.com> | 2024-01-18 14:50:21 +0100 |
| commit | b01a74b3ca6fd51b62c67733ba7c3280fa6c5d26 (patch) | |
| tree | 100fb4592dfd1285fee03e666d8d0ee0e8eced91 /net/mac80211/sta_info.c | |
| parent | wifi: cfg80211/mac80211: remove dependency on non-existing option (diff) | |
| download | linux-b01a74b3ca6fd51b62c67733ba7c3280fa6c5d26.tar.xz linux-b01a74b3ca6fd51b62c67733ba7c3280fa6c5d26.zip | |
wifi: mac80211: fix potential sta-link leak
When a station is allocated, links are added but not
set to valid yet (e.g. during connection to an AP MLD),
we might remove the station without ever marking links
valid, and leak them. Fix that.
Fixes: cb71f1d136a6 ("wifi: mac80211: add sta link addition/removal")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Reviewed-by: Ilan Peer <ilan.peer@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://msgid.link/20240111181514.6573998beaf8.I09ac2e1d41c80f82a5a616b8bd1d9d8dd709a6a6@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'net/mac80211/sta_info.c')
| -rw-r--r-- | net/mac80211/sta_info.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c index 0ba613dd1cc4..c33decbb97f2 100644 --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c @@ -404,7 +404,10 @@ void sta_info_free(struct ieee80211_local *local, struct sta_info *sta) int i; for (i = 0; i < ARRAY_SIZE(sta->link); i++) { - if (!(sta->sta.valid_links & BIT(i))) + struct link_sta_info *link_sta; + + link_sta = rcu_access_pointer(sta->link[i]); + if (!link_sta) continue; sta_remove_link(sta, i, false); |