diff options
| author | Jeremy Kerr <jk@codeconstruct.com.au> | 2022-02-18 05:25:54 +0100 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-02-19 06:24:29 +0100 |
| commit | 86cdfd63f25dc1c8f241ee70c58da3c10472b76e (patch) | |
| tree | 1e158db45b1ed7454f438c240ae3924b36a49b03 /net/mctp/route.c | |
| parent | mctp: replace mctp_address_ok with more fine-grained helpers (diff) | |
| download | linux-86cdfd63f25dc1c8f241ee70c58da3c10472b76e.tar.xz linux-86cdfd63f25dc1c8f241ee70c58da3c10472b76e.zip | |
mctp: add address validity checking for packet receive
This change adds some basic sanity checks for the source and dest
headers of packets on initial receive.
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/mctp/route.c')
| -rw-r--r-- | net/mctp/route.c | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/net/mctp/route.c b/net/mctp/route.c index 6a11d78cfbab..fe6c8bf1ec2c 100644 --- a/net/mctp/route.c +++ b/net/mctp/route.c @@ -1092,6 +1092,17 @@ static int mctp_pkttype_receive(struct sk_buff *skb, struct net_device *dev, if (mh->ver < MCTP_VER_MIN || mh->ver > MCTP_VER_MAX) goto err_drop; + /* source must be valid unicast or null; drop reserved ranges and + * broadcast + */ + if (!(mctp_address_unicast(mh->src) || mctp_address_null(mh->src))) + goto err_drop; + + /* dest address: as above, but allow broadcast */ + if (!(mctp_address_unicast(mh->dest) || mctp_address_null(mh->dest) || + mctp_address_broadcast(mh->dest))) + goto err_drop; + /* MCTP drivers must populate halen/haddr */ if (dev->type == ARPHRD_MCTP) { cb = mctp_cb(skb); |