diff options
| author | Geliang Tang <geliang.tang@suse.com> | 2022-01-06 23:06:37 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-01-07 12:29:45 +0100 |
| commit | 110b6d1fe98fd7af9893992459b651594d789293 (patch) | |
| tree | 8b71f0a14275956c1a14f7a4c2a8beee888236ea /net/mptcp/options.c | |
| parent | mptcp: fix opt size when sending DSS + MP_FAIL (diff) | |
| download | linux-110b6d1fe98fd7af9893992459b651594d789293.tar.xz linux-110b6d1fe98fd7af9893992459b651594d789293.zip | |
mptcp: fix a DSS option writing error
'ptr += 1;' was omitted in the original code.
If the DSS is the last option -- which is what we have most of the
time -- that's not an issue. But it is if we need to send something else
after like a RM_ADDR or an MP_PRIO.
Fixes: 1bff1e43a30e ("mptcp: optimize out option generation")
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Geliang Tang <geliang.tang@suse.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/mptcp/options.c')
| -rw-r--r-- | net/mptcp/options.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/mptcp/options.c b/net/mptcp/options.c index 96c6efdd48bc..6661b1d6520f 100644 --- a/net/mptcp/options.c +++ b/net/mptcp/options.c @@ -1319,6 +1319,7 @@ void mptcp_write_options(__be32 *ptr, const struct tcp_sock *tp, put_unaligned_be32(mpext->data_len << 16 | TCPOPT_NOP << 8 | TCPOPT_NOP, ptr); } + ptr += 1; } } else if (OPTIONS_MPTCP_MPC & opts->suboptions) { u8 len, flag = MPTCP_CAP_HMAC_SHA256; |