diff options
author | Eric Dumazet <edumazet@google.com> | 2019-12-12 21:55:30 +0100 |
---|---|---|
committer | Jakub Kicinski <jakub.kicinski@netronome.com> | 2019-12-14 06:58:40 +0100 |
commit | ee2aabd3fc2eef4c1a0ebdadccc76fbff74b94fc (patch) | |
tree | ff49c797d50165533687b248d7531010a9b24339 /net/netlink/af_netlink.c | |
parent | tcp: do not send empty skb from tcp_write_xmit() (diff) | |
download | linux-ee2aabd3fc2eef4c1a0ebdadccc76fbff74b94fc.tar.xz linux-ee2aabd3fc2eef4c1a0ebdadccc76fbff74b94fc.zip |
tcp: refine tcp_write_queue_empty() implementation
Due to how tcp_sendmsg() is implemented, we can have an empty
skb at the tail of the write queue.
Most [1] tcp_write_queue_empty() callers want to know if there is
anything to send (payload and/or FIN)
Instead of checking if the sk_write_queue is empty, we need
to test if tp->write_seq == tp->snd_nxt
[1] tcp_send_fin() was the only caller that expected to
see if an skb was in the write queue, I have changed the code
to reuse the tcp_write_queue_tail() result.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Diffstat (limited to 'net/netlink/af_netlink.c')
0 files changed, 0 insertions, 0 deletions