diff options
| author | Pablo Neira Ayuso <pablo@netfilter.org> | 2012-02-24 15:30:15 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-02-26 20:10:06 +0100 |
| commit | 80d326fab534a5380e8f6e509a0b9076655a9670 (patch) | |
| tree | 57c636de934b3f8abb7db9bcde64360ecc4eaf66 /net/netlink/genetlink.c | |
| parent | Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsh... (diff) | |
| download | linux-80d326fab534a5380e8f6e509a0b9076655a9670.tar.xz linux-80d326fab534a5380e8f6e509a0b9076655a9670.zip | |
netlink: add netlink_dump_control structure for netlink_dump_start()
Davem considers that the argument list of this interface is getting
out of control. This patch tries to address this issue following
his proposal:
struct netlink_dump_control c = { .dump = dump, .done = done, ... };
netlink_dump_start(..., &c);
Suggested by David S. Miller.
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netlink/genetlink.c')
| -rw-r--r-- | net/netlink/genetlink.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index a1154717219e..9f40441d7a7d 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c @@ -563,8 +563,13 @@ static int genl_rcv_msg(struct sk_buff *skb, struct nlmsghdr *nlh) return -EOPNOTSUPP; genl_unlock(); - err = netlink_dump_start(net->genl_sock, skb, nlh, - ops->dumpit, ops->done, 0); + { + struct netlink_dump_control c = { + .dump = ops->dumpit, + .done = ops->done, + }; + err = netlink_dump_start(net->genl_sock, skb, nlh, &c); + } genl_lock(); return err; } |