diff options
| author | Nicolas Dichtel <nicolas.dichtel@6wind.com> | 2018-03-14 21:10:23 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-03-16 17:34:48 +0100 |
| commit | 02a2385f37a7c6594c9d89b64c4a1451276f08eb (patch) | |
| tree | 6d546ca371da37ba8c91bfc84f50f600c9c0ec9c /net/netlink/genetlink.c | |
| parent | qede: Fix qedr link update (diff) | |
| download | linux-02a2385f37a7c6594c9d89b64c4a1451276f08eb.tar.xz linux-02a2385f37a7c6594c9d89b64c4a1451276f08eb.zip | |
netlink: avoid a double skb free in genlmsg_mcast()
nlmsg_multicast() consumes always the skb, thus the original skb must be
freed only when this function is called with a clone.
Fixes: cb9f7a9a5c96 ("netlink: ensure to loop over all netns in genlmsg_multicast_allns()")
Reported-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netlink/genetlink.c')
| -rw-r--r-- | net/netlink/genetlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c index 6f02499ef007..b9ce82c9440f 100644 --- a/net/netlink/genetlink.c +++ b/net/netlink/genetlink.c @@ -1106,7 +1106,7 @@ static int genlmsg_mcast(struct sk_buff *skb, u32 portid, unsigned long group, if (!err) delivered = true; else if (err != -ESRCH) - goto error; + return err; return delivered ? 0 : -ESRCH; error: kfree_skb(skb); |