diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-04-22 22:22:51 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-04-25 07:47:58 +0200 |
| commit | 7a3b68434b1b5fb7b9a6184efb26822cd1a54cc8 (patch) | |
| tree | 6b2e5cbcfca48b1229396fd19773386f7eefd62e /net/netrom/af_netrom.c | |
| parent | appletalk: info leak in ->getname() (diff) | |
| download | linux-7a3b68434b1b5fb7b9a6184efb26822cd1a54cc8.tar.xz linux-7a3b68434b1b5fb7b9a6184efb26822cd1a54cc8.zip | |
netrom: info leak in ->getname()
The sockaddr_ax25 struct has a 3 byte hole between ->sax25_call and
->sax25_ndigis. I've added a memset to avoid leaking uninitialized
stack data to userspace.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netrom/af_netrom.c')
| -rw-r--r-- | net/netrom/af_netrom.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c index 103bd704b5fc..ec0c80fde69f 100644 --- a/net/netrom/af_netrom.c +++ b/net/netrom/af_netrom.c @@ -834,6 +834,8 @@ static int nr_getname(struct socket *sock, struct sockaddr *uaddr, struct sock *sk = sock->sk; struct nr_sock *nr = nr_sk(sk); + memset(&sax->fsa_ax25, 0, sizeof(struct sockaddr_ax25)); + lock_sock(sk); if (peer != 0) { if (sk->sk_state != TCP_ESTABLISHED) { |