diff options
| author | Herbert Xu <herbert@gondor.apana.org.au> | 2007-10-19 07:37:58 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2007-10-19 07:37:58 +0200 |
| commit | ce0e32e65f70337e0732c97499b643205fa8ea31 (patch) | |
| tree | 3f3a4a48210a1e4208a8ed5507f2e3269a7b79da /net/netrom | |
| parent | [INET]: Justification for local port range robustness. (diff) | |
| download | linux-ce0e32e65f70337e0732c97499b643205fa8ea31.tar.xz linux-ce0e32e65f70337e0732c97499b643205fa8ea31.zip | |
[NET]: Fix possible dev_deactivate race condition
The function dev_deactivate is supposed to only return when
all outstanding transmissions have completed. Unfortunately
it is possible for store operations in the driver's transmit
function to only become visible after dev_deactivate returns.
This patch fixes this by taking the queue lock after we see
the end of the queue run. This ensures that all effects of
any previous transmit calls are visible.
If however we detect that there is another queue run occuring,
then we'll warn about it because this should never happen as
we have pointed dev->qdisc to noop_qdisc within the same queue
lock earlier in the functino.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/netrom')
0 files changed, 0 insertions, 0 deletions